Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1306 add reference property for storedfiles #1309

Merged
merged 11 commits into from
Apr 17, 2023
Merged

1306 add reference property for storedfiles #1309

merged 11 commits into from
Apr 17, 2023

Conversation

raduiordache
Copy link
Contributor

@raduiordache raduiordache commented Apr 3, 2023 •
edited
Loading

Fixes #

Checklist:

  • My code follows the pykechain style
    • I added type hinting to all functions
    • I added documentation for all public functions
    • I locally used tox to check for dists and docs errors
    • My code passes the pep8 and flake8 linting checks and no warnings
    • I removed unused imports, using Code > Optimize Imports in PyCharm
    • I used black to format the new code
  • I have added tests that prove my fix is effective or that my feature works
    • I committed fresh test cassettes
    • I have proper test coverage (don't decline the coverage of the test)
  • I asked another teammate to review the code
  • I update the Changelog.md with the appropriate changes.

@raduiordache raduiordache linked an issue Apr 3, 2023 that may be closed by this pull request
Add reference property for StoredFiles #1306
Closed
@raduiordache raduiordache self-assigned this Apr 5, 2023
@raduiordache raduiordache requested a review from KaczuH April 5, 2023 12:00
KaczuH
KaczuH reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@KaczuH KaczuH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raduiordache Looks ok. I made some minor comments. Nothing big.

pykechain/models/input_checks.py Outdated Show resolved Hide resolved
pykechain/models/property_reference.py Outdated Show resolved Hide resolved
pykechain/client.py Show resolved Hide resolved
@raduiordache raduiordache merged commit a9cbc90 into main Apr 17, 2023
@raduiordache raduiordache deleted the 1306-add-reference-property-for-storedfiles branch April 17, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaczuH KaczuH KaczuH left review comments

Assignees

@raduiordache raduiordache

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reference property for StoredFiles
2 participants
@raduiordache @KaczuH